Kusto: Add kusto API #7117

radennis · 2018-09-02T12:38:14Z

Description

Design Review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/18

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review
- the cmdlet markdown files were generated using the platyPS module

deathly809 · 2018-09-02T19:12:44Z

Why do you have a Nuget in the localfeed? I saw you had a PR in the SDK but they closed it because you never responded to their requests it looked like.

elirazcc · 2018-09-03T13:39:23Z

@deathly809 In the past we had that nuget only in the localfeed. I will fix that.

maddieclayton · 2018-09-04T20:06:06Z

@radennis Please fill out a cmdlet review here: https://github.com/Azure/azure-powershell-cmdlet-review-pr, or link one if you have completed your design review.

elirazcc · 2018-09-05T08:50:08Z

@maddieclayton I will be replacing @radennis. Desing review was already approved in https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/18

maddieclayton

Please also pull from upstream preview, as this might fix build failures.

...sourceManager/PowerBIEmbedded/Commands.PowerBI/Commands/NewAzureRmPowerBIEmbeddedCapacity.cs

src/ResourceManager/PowerBIEmbedded/Commands.PowerBI/Properties/Resources.Designer.cs

elirazcc · 2018-09-06T10:51:45Z

@maddieclayton I think we have already pulled from upstream preview. How can I check that?

elirazcc · 2018-09-06T13:16:19Z

@maddieclayton When compile on my machine build works. Why is it failing here?

deathly809 · 2018-09-06T16:32:39Z

@elirazcc Looks like you need to pull from upstream, either merge or rebase. You are referring to things which don't exist anymore. The pulled out the common runtime, just check out what other csprojs are doing now.

src/ResourceManager/Kusto/Commands.Kusto/Commands.Kusto.csproj

maddieclayton · 2018-11-05T21:23:31Z

Closing for inactivity - please reopen when you are able to fix the build.

oflipman · 2018-12-07T11:26:19Z

@maddieclayton @MiYanni @selasagi
Can some one please review this PR?

src/ResourceManager/Kusto/Commands.Kusto.Test/Commands.Kusto.Test.csproj

src/ResourceManager/Kusto/Commands.Kusto.Test/ScenarioTests/Common.ps1

src/ResourceManager/Kusto/Commands.Kusto.Test/ScenarioTests/KustoClusterTests.ps1

src/ResourceManager/Kusto/Commands.Kusto/Models/KustoClient.cs

src/ResourceManager/Kusto/Commands.Kusto/Utilities/KustoUtils.cs

tools/StaticAnalysis/Exceptions/AzureRM.Kusto/AssemblyVersionConflict.csv

src/ResourceManager/Kusto/Kusto.sln

src/ResourceManager/Kusto/Commands.Kusto/AzureRM.Kusto.psd1

…into AddKusto-2 # Conflicts: # src/ResourceManager/Kusto/Commands.Kusto.Test/ScenarioTests/KustoClusterTests.cs # src/ResourceManager/Kusto/Commands.Kusto.Test/ScenarioTests/KustoDatabaseTests.cs # src/ResourceManager/Kusto/Commands.Kusto.Test/ScenarioTests/KustoTestsBase.cs # src/ResourceManager/Kusto/Kusto.sln

src/ResourceManager/Kusto/Commands.Kusto.Test/Commands.Kusto.Test.Netcore.csproj

src/ResourceManager/Kusto/Commands.Kusto/Commands.Kusto.Netcore.csproj

src/ResourceManager/Kusto/Commands.Kusto/Az.Kusto.psd1

…into AddKusto-2

src/ResourceManager/Kusto/Commands.Kusto.Test/ScenarioTests/Common.ps1

src/ResourceManager/Kusto/Commands.Kusto/Az.Kusto.psd1

src/ResourceManager/Kusto/Commands.Kusto/Commands/GetAzureRmKustoDatabase.cs

src/ResourceManager/Kusto/Commands.Kusto/Commands/NewAzureRmKustoDatabase.cs

src/ResourceManager/Kusto/Commands.Kusto/Commands/UpdateAzureRmKustoCluster.cs

src/ResourceManager/Kusto/Commands.Kusto/Commands/UpdateAzureRmKustoDatabase.cs

src/ResourceManager/Kusto/Commands.Kusto/Models/KustoClient.cs

src/ResourceManager/Kusto/Commands.Kusto/Utilities/KustoUtils.cs

addressed

radennis added 2 commits September 2, 2018 15:21

Kusto: Add kusto

5cfd159

Remove database type

1ff7e18

azuresdkci1x added the needs-review label Sep 2, 2018

elirazcc requested a review from selasagi September 3, 2018 13:39

maddieclayton added Cmdlet Review Required ⚠️ and removed needs-review labels Sep 4, 2018

maddieclayton assigned radennis Sep 4, 2018

elirazcc assigned maddieclayton and elirazcc Sep 5, 2018

maddieclayton suggested changes Sep 5, 2018

View reviewed changes

...sourceManager/PowerBIEmbedded/Commands.PowerBI/Commands/NewAzureRmPowerBIEmbeddedCapacity.cs Outdated Show resolved Hide resolved

src/ResourceManager/PowerBIEmbedded/Commands.PowerBI/Properties/Resources.Designer.cs Outdated Show resolved Hide resolved

maddieclayton added Cmdlet Review Complete and removed Cmdlet Review Required ⚠️ labels Sep 5, 2018

maddieclayton removed their assignment Sep 5, 2018

maddieclayton added the needs-revision label Sep 5, 2018

maddieclayton unassigned radennis Sep 5, 2018

elirazcc added 2 commits September 6, 2018 13:25

Addressed comments

5f1d3c8

Fix powerBI file

db6cf16

elirazcc removed the needs-revision label Sep 6, 2018

elirazcc assigned maddieclayton Sep 6, 2018

elirazcc added the needs-revision label Sep 6, 2018

Merge branch 'preview' into AddKusto-2

de216ef

cormacpayne reviewed Sep 11, 2018

View reviewed changes

src/ResourceManager/Kusto/Commands.Kusto/Commands.Kusto.csproj Outdated Show resolved Hide resolved

cormacpayne unassigned maddieclayton Sep 11, 2018

maddieclayton closed this Nov 5, 2018

maddieclayton and others added 2 commits November 20, 2018 13:11

fix test project and psd1

5910d24

Added tests and added more commands

17e7da8

oflipman reopened this Dec 5, 2018

Removed ClearAzureRmDefault

8a75830

maddieclayton changed the base branch from preview to master December 5, 2018 20:33

Merge branch 'master' into AddKusto-2

3dcab92

maddieclayton suggested changes Dec 7, 2018

View reviewed changes

oflipman and others added 6 commits December 12, 2018 09:54

Fixed comments

4d8f5c1

latzest

915d4b6

Merge from master

8eff266

fixed breaking changes with master

e987762

Fix Kusto build and test issues.

db8a079

MiYanni suggested changes Dec 12, 2018

View reviewed changes

src/ResourceManager/Kusto/Commands.Kusto.Test/Commands.Kusto.Test.Netcore.csproj Outdated Show resolved Hide resolved

src/ResourceManager/Kusto/Commands.Kusto/Commands.Kusto.Netcore.csproj Outdated Show resolved Hide resolved

MiYanni previously requested changes Dec 13, 2018

View reviewed changes

src/ResourceManager/Kusto/Commands.Kusto/Az.Kusto.psd1 Outdated Show resolved Hide resolved

src/ResourceManager/Kusto/Commands.Kusto/Az.Kusto.psd1 Outdated Show resolved Hide resolved

MiYanni and others added 6 commits December 13, 2018 12:30

Fixed Kusto test running.

42dc29f

Merge branch 'master' into AddKusto-2

62b70d9

Fixed comments

586b005

Merge branch 'AddKusto-2' of https://github.com/Azure/azure-powershell …

5c78e15

…into AddKusto-2

Merge branch 'master' into AddKusto-2

d1dafa9

Update MissingAssemblies.csv

3646561

maddieclayton suggested changes Dec 18, 2018

View reviewed changes

fixed comments

69345c0

maddieclayton approved these changes Dec 18, 2018

View reviewed changes

maddieclayton merged commit 96c6603 into master Dec 18, 2018

maddieclayton deleted the AddKusto-2 branch December 18, 2018 20:24

Kusto: Add kusto API #7117

Kusto: Add kusto API #7117

Uh oh!

Conversation

radennis commented Sep 2, 2018 • edited by MiYanni Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

deathly809 commented Sep 2, 2018

Uh oh!

elirazcc commented Sep 3, 2018

Uh oh!

maddieclayton commented Sep 4, 2018

Uh oh!

elirazcc commented Sep 5, 2018

Uh oh!

maddieclayton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

elirazcc commented Sep 6, 2018

Uh oh!

elirazcc commented Sep 6, 2018

Uh oh!

deathly809 commented Sep 6, 2018

Uh oh!

Uh oh!

maddieclayton commented Nov 5, 2018

Uh oh!

oflipman commented Dec 7, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

radennis commented Sep 2, 2018 •

edited by MiYanni

Loading