Skip to content

Conversation

@chlowell
Copy link
Member

@chlowell chlowell commented Apr 8, 2025

No description provided.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@chlowell chlowell marked this pull request as ready for review April 8, 2025 23:33
Copilot AI review requested due to automatic review settings April 8, 2025 23:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure Identity SDK Improvements Apr 9, 2025
@chlowell chlowell requested a review from heaths April 9, 2025 15:33
@heaths
Copy link
Member

heaths commented Apr 9, 2025

It was likely a merge conflict, but now I got to wondering: why was the PR merged? I was waiting for @chlowell to sign off.

@tot0
Copy link
Contributor

tot0 commented Apr 9, 2025

It was likely a merge conflict, but now I got to wondering: why was the PR merged? I was waiting for @chlowell to sign off.

I came back to check as it came up internally that we're still on my fork of azure_identity. It had been almost 2 weeks and the PR was able to be merged so I clicked it, after checking the CHANGELOG.md was still valid.

Sorry if I wasn't support to merge it. Happy for it to be reverted if you think there's issues, I just want to get back to mainline crates eventually :)

@chlowell chlowell requested a review from heaths April 9, 2025 17:24
@chlowell chlowell merged commit 92fee1e into Azure:main Apr 9, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure Identity SDK Improvements Apr 9, 2025
@chlowell chlowell deleted the release branch April 9, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Identity The azure_identity crate

Projects

Development

Successfully merging this pull request may close these issues.

4 participants