- 
                Notifications
    
You must be signed in to change notification settings  - Fork 108
 
Fix emulator response unexpected Header:x-ms-error-code #2019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix emulator response unexpected Header:x-ms-error-code #2019
Conversation
| 
           There're some other methods that can also return   | 
    
| 
           Try to add some unit tests under   | 
    
… duong.phanthai/fix-connection-exist-async
        
          
                src/Microsoft.Azure.SignalR.Emulator/Controllers/SignalRServiceEmulatorWebApi.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/Microsoft.Azure.SignalR.Emulator/HubEmulator/DynamicHubContext.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                src/Microsoft.Azure.SignalR.Emulator/Controllers/SignalRServiceEmulatorWebApi.cs
          
            Show resolved
            Hide resolved
        
      | 
           hi @zackliu I have resolved the review. Can u help double check that I can use:   | 
    
Summary of the changes (Less than 80 chars)
Describe the bug
How to fix:
Add the expected header
x-ms-error-codefor responses from the API that checks for existence in the emulator (CheckConnectionExistence, CheckGroupExistence, CheckUserExistence). The expected value of x-ms-error-code should be the same as what is defined in management to avoid throwing exceptions in this function.azure-signalr/src/Microsoft.Azure.SignalR.Management/RestHubLifetimeManager.cs
Line 276 in fa7b063
Fixes #1912