Skip to content

Conversation

@abhishekkumams
Copy link
Contributor

@abhishekkumams abhishekkumams commented Nov 24, 2022

Why make this change?

  • Closes #
    • To Verify that DAB engine supports CRUD operations on tables with calculated columns.

What is this change?

  • Updating SQL files (MSSQL/MYSQL/POSTGRES) to add a new table containing calculated columns.
  • Added Tests to verify CRUD operations on them.

How was this tested?

  • Integration Tests

Sample Request(s)

image
image
image

NOTE:

Update Mutation for tables with computed columns currently fail for MySQL( created an issue #1001 to handle the same)

@abhishekkumams abhishekkumams self-assigned this Nov 24, 2022
@abhishekkumams abhishekkumams added mssql pgsql mysql an issue that applies to all relational databases, same as labeling with `mssql` `mysql` and `pgsql` testing Test related issue. engine issues that require change in engine code labels Nov 24, 2022
@abhishekkumams abhishekkumams added this to the Nov2022 milestone Nov 24, 2022
@abhishekkumams abhishekkumams changed the title Verify support for calculated columns Verify support for computed columns Nov 25, 2022
… dev/abhishekkuma/make-sure-calculated-columns-are-supported
Copy link
Contributor

@severussundar severussundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Input Types generated for the create, update and delete mutations, does the computed column show up as an optional field?

IMO, computed columns shouldn't come up because we wouldn't want any kind of input directly provided to the computed columns.

Copy link
Contributor

@severussundar severussundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after answering few questions!

@abhishekkumams
Copy link
Contributor Author

In the Input Types generated for the create, update and delete mutations, does the computed column show up as an optional field?

IMO, computed columns shouldn't come up because we wouldn't want any kind of input directly provided to the computed columns.

the computed columns show up as optional column, and if we would try to update it, it will give an error stating that it's a computed column and cannot be modified.

@abhishekkumams abhishekkumams merged commit c745c85 into main Nov 29, 2022
@abhishekkumams abhishekkumams deleted the dev/abhishekkuma/make-sure-calculated-columns-are-supported branch November 29, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine issues that require change in engine code mssql pgsql mysql an issue that applies to all relational databases, same as labeling with `mssql` `mysql` and `pgsql` testing Test related issue.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Make sure calculated columns are supported

4 participants