-
Notifications
You must be signed in to change notification settings - Fork 288
Verify support for computed columns #1000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify support for computed columns #1000
Conversation
…rted' of https://github.com/Azure/data-api-builder into dev/abhishekkuma/make-sure-calculated-columns-are-supported
… dev/abhishekkuma/make-sure-calculated-columns-are-supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the Input Types generated for the create, update and delete mutations, does the computed column show up as an optional field?
IMO, computed columns shouldn't come up because we wouldn't want any kind of input directly provided to the computed columns.
src/Service.Tests/SqlTests/GraphQLMutationTests/MySqlGraphQLMutationTests.cs
Outdated
Show resolved
Hide resolved
severussundar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after answering few questions!
…rted' of https://github.com/Azure/data-api-builder into dev/abhishekkuma/make-sure-calculated-columns-are-supported
the computed columns show up as optional column, and if we would try to update it, it will give an error stating that it's a computed column and cannot be modified. |
Why make this change?
What is this change?
How was this tested?
Sample Request(s)
NOTE:
Update Mutation for tables with computed columns currently fail for MySQL( created an issue #1001 to handle the same)