Reading CosmosDB options from data-source section #1003
Conversation
mbhaskar
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
jarupatj,
junsu0ms,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
|
Do any of the existing CosmosDB config files need to be changed to be compatible with this change? Doesn't this modify how the config file should be parsed, which maybe I missed config file changes in a different PR? |
Fixing Init tests
The dab-config file is the one that changes. Ayush had a PR that changes CLI to generate options inside the data-source |
| _graphQLSingularTypeToEntityNameMap = _runtimeConfig.GraphQLSingularTypeToEntityNameMap; | ||
|
|
||
| CosmosDbOptions? cosmosDb = _runtimeConfig.CosmosDb; | ||
| CosmosDbOptions? cosmosDb = _runtimeConfig.DataSource.CosmosDbNoSql; |
There was a problem hiding this comment.
nit: this section looks like it could be simplified. the conditional could just check _runtimeConfig.DataSource.CosmosDbNoSql for null and assign that value to _cosmosDb if not null.
Why make this change?
Fixes #959
Reading comsos options from data-source/options instead of "cosmos" object.
Follow up of PR #993
What is this change?
This PR initalizes comsos metadata provider with cosmos database, container and schema options read from data-source/options path
How was this tested?
Existing test should be good.
Sample Request(s)