-
Notifications
You must be signed in to change notification settings - Fork 288
Managed Identity Support for Pg #1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
seantleonard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit, otherwise looks good :)
src/Service.Tests/Unittests/PostgreSqlQueryExecutorUnitTests.cs
Outdated
Show resolved
Hide resolved
|
I think it's fair to denote |
Aniruddh25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for hosted scenario, but unclear waiting on how "USE DEFAULT" will be set by user and identified by RuntimeConfigProvider
|
Through offline discussion, it was decided to tackle this as follows:
|
I will again be OOF starting 12/12, dont want my review to block the merge of this PR
src/Service.Tests/Unittests/PostgreSqlQueryExecutorUnitTests.cs
Outdated
Show resolved
Hide resolved
Aniruddh25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pushing through this change for the Nov2022 release, really appreciate it!
Left 1 optimization for passwordless scenarios, otherwise LGTM.
544a141 to
835975f
Compare
Why make this change?
What is this change?
PostgreSqlQueryExecutorinspired by how managed identity was supported for Sql Server.How was this tested?