Skip to content

Conversation

@seantleonard
Copy link
Contributor

Why make this change?

  • Closes Authentication Enhancement -> App Service Environment Check #596
    • Check to prevent users from accidentally hosting the engine in Production mode with AppService set as the authentication provider when the environment is NOT AppService.
  • In a real App Service environment, the following environment variables will be present:
    • WEBSITE_AUTH_ENABLED with value true
    • APPSERVICESAUTH_IDENTITYPROVIDER_ENVVAR with value such as AzureActiveDirectory

What is this change?

How was this tested?

  • Integration Tests
  • Unit Tests

Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Aniruddh25
Copy link
Collaborator

Aniruddh25 commented Dec 3, 2022

While this is good to merge, I think the issue that this is closing has a misleading heading: SWA Environment Check. As far as I understand, we are NOT doing any environment checks for SWA but this is for AppService in a self hosted scenario.

Copy link
Contributor

@ayush3797 ayush3797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ayush3797 ayush3797 merged commit 5372d37 into main Dec 5, 2022
@ayush3797 ayush3797 deleted the dev/seleonar/appServiceDetection branch December 5, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Authentication Enhancement -> App Service Environment Check

5 participants