-
Notifications
You must be signed in to change notification settings - Fork 289
App Service Environment Detection for Production Mode #1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Service/AuthenticationHelpers/AppServiceAuthenticationInformation.cs
Show resolved
Hide resolved
Aniruddh25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
While this is good to merge, I think the issue that this is closing has a misleading heading: |
ayush3797
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Why make this change?
WEBSITE_AUTH_ENABLEDwith valuetrueAPPSERVICESAUTH_IDENTITYPROVIDER_ENVVARwith value such asAzureActiveDirectoryWhat is this change?
Microsoft.Identity.Webcode: https://github.com/AzureAD/microsoft-identity-web/blob/4085a499afb8be6e02c5d24182cbdbc5a35a4031/src/Microsoft.Identity.Web/AppServicesAuth/AppServicesAuthenticationInformation.csHow was this tested?