Set the database name through configuration #1012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbhaskar
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
jarupatj,
junsu0ms,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
seantleonard
approved these changes
Dec 3, 2022
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
Looks good, nit + question.
Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
Aniruddh25
approved these changes
Dec 3, 2022
ayush3797
approved these changes
Dec 5, 2022
tarazou9
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Fixes #960
This PR make sure we honor the database name being set by SWA during runtime configuration
What is this change?
Currently Cosmos picks up the database name from the options in the dab-config.
This PR enables the ability to set the database through Configuration controller.
How was this tested?