Failing Config validation for invalid claims in SWA #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 6, 2022 14:06
ayush3797
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
gledis69,
jarupatj,
junsu0ms,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
ayush3797
changed the title
Aniruddh25
reviewed
Dec 6, 2022
Aniruddh25
approved these changes
Dec 6, 2022
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick fix! Can even make it to Nov2022 now :)
Aniruddh25
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Currently the payload for SWA in X-MS-CLIENT-PRINCIPAL header does not contain any claims. We self-populate claims like
userIdanduserDetailsinto the ClaimsPrincipal object ourselves and hence any claim other than these 2 referenced in the database policy should lead to a config validation error.The changes made in this PR are to address the same.
What is this change?
An additional check is added to database policy validation where the validation would fail if any claim other than
userIdoruserDetailsis referenced when the authentication provider isStaticWebApps.How was this tested?
TestInvalidClaimsForStaticWebAppsis added inConfigValidationUnitTestsclass to unit test the change.