Log GQL Entity Information #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronburtle
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
jarupatj,
junsu0ms,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
Aniruddh25
reviewed
Dec 7, 2022
Aniruddh25
requested changes
Dec 7, 2022
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Need to fix what we log as GraphQL Entity
Collaborator
|
nit: the description should provide the exact issue number after the phrase |
Aniruddh25
reviewed
Dec 7, 2022
seantleonard
requested changes
Dec 7, 2022
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
Might be worth considering whether delaying the logging of graphQL entity names
seantleonard
reviewed
Dec 8, 2022
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
last few suggestions
seantleonard
approved these changes
Dec 8, 2022
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
Thanks for addressing comments. looks concise. Two small change suggestions and should be good to go.
Aniruddh25
reviewed
Dec 8, 2022
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
Aniruddh25
reviewed
Dec 8, 2022
Aniruddh25
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #968
We are currently logging only those entities loaded for REST, this adds GQL entities to the logging.
What is this change?
On startup when we map the GQL types to entity names we log the relevant entities.
This happens within
MapGraphQLSingularTypeToEntityNameHow was this tested?
Verified on startup that the calls are made into the logger when appropriate.
Sample Request(s)
Startup the service with valid entities for GQL.