Clarify the usage of config files on startup #1026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronburtle
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
jarupatj,
junsu0ms,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
Aniruddh25
reviewed
Dec 7, 2022
Collaborator
|
nit: There is no need to provide a screenshot of the change in the description, the reviewers are going to see it in the files changed. Keep the description specific to the high level of what the change is and why it is needed. |
abhishekkumams
approved these changes
Dec 7, 2022
seantleonard
reviewed
Dec 7, 2022
…ub.com/Azure/hawaii-gql into dev/aaronburtle/HarmonizeConfigLogging
Aniruddh25
approved these changes
Dec 8, 2022
seantleonard
approved these changes
Dec 8, 2022
Aniruddh25
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #967
The information that we log regarding configuration files is currently confusing. This change will clarify which files are simply being checked for existence and which are actually being loaded.
What is this change?
Certain calls are made to locate config files. We simply clarify what is happening within these calls when we log within
RuntimeConfigPathandUtilsHow was this tested?
Verified the information during startup.
Sample Request(s)
Start the service.