Skip to content

Conversation

tomfroehle
Copy link
Contributor

@tomfroehle tomfroehle commented Mar 13, 2025

Duplicates #2473 because I cannot contribute with my enterprise account anymore.

Original PR description:

Why make this change?

What is this change?

How was this tested?

  • Integration Tests -> I'm happy to extend the integration tests, if this fix seems like a good idea
  • Unit Tests
  • manually

Sample Request(s)

Sample configuraiton:

"MyTable": {
  "source": {
    "object": "schema.\"MyTable\"",
    "type": "table"
  }
}

@tomfroehle
Copy link
Contributor Author

@microsoft-github-policy-service agree

@aaronburtle
Copy link
Contributor

Thanks for following up!

@JerryNixon
Copy link
Contributor

What happens to existing customers who have indicated their table name but have used the incorrect casing for those tables? Will this break those customers?

@Aniruddh25
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Aniruddh25 Aniruddh25 linked an issue Mar 14, 2025 that may be closed by this pull request
1 task
@Aniruddh25
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@Aniruddh25
Copy link
Collaborator

What happens to existing customers who have indicated their table name but have used the incorrect casing for those tables? Will this break those customers?

Good question. Lets consider the 2 cases if customers have used incorrect casing,

  1. and their table names are case sensitive - it must not have been working for them anyway right now without the quotes. After adding the quotes, it will still not work since they are doing incorrect casing.

  2. and their table names are case insensitive - adding quotes shouldn't be a problem, since the names are case insensitive. Should continue to work. @aaronburtle, could you please confirm this scenario?

Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving existing changes. Any leftover testing should follow up in the subsequent issue tracked by @aaronburtle

@Aniruddh25 Aniruddh25 merged commit eefc57a into Azure:main Mar 16, 2025
11 checks passed
@aaronburtle aaronburtle self-assigned this May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Quoted Table name are not supported

5 participants