Allow access to health endpoint as per defined roles #2632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Azure/data-api-builder into dev/sezalchug/healthConfigFiles
…lthCheckExecution
… dev/sezalchug/healthCheckExecution
Aniruddh25
reviewed
Apr 2, 2025
Aniruddh25
reviewed
Apr 2, 2025
Aniruddh25
reviewed
Apr 2, 2025
Aniruddh25
requested changes
Apr 2, 2025
|
nit: please provide a better title to the PR that explains what this PR is doing. |
Aniruddh25
reviewed
Apr 3, 2025
Aniruddh25
reviewed
Apr 4, 2025
added 3 commits
April 4, 2025 19:48
… dev/sezalchug/rolesHealthCheck
Aniruddh25
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
RubenCerna2079
approved these changes
Apr 4, 2025
Aniruddh25
approved these changes
Apr 4, 2025
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #2531
What is this change?
This PR involves creating another parameter in the runtime config which defines the allowed roles for the health endpoint.
src/Config/Converters/RuntimeHealthOptionsConvertorFactory.cswhich takes care of serialization and deserialization of runtime config custom way.Scenarios
How was this tested?
Sample Request(s)
Roles: ["authenticated"]
Mode: Development or Production
Roles: Not Configured
Mode: Development
Mode: Production
Roles: ["admin"]
Mode: Development or Production