Hot Reload for Loggers #2634
Merged
Hot Reload for Loggers #2634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenCerna2079
requested review from
Aniruddh25,
aaronburtle,
neeraj-sharma2592,
ravishetye,
rohkhann,
sezal98 and
sourabh1007
as code owners
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
RubenCerna2079
force-pushed
the
dev/rubencerna/HotReload_Logger
branch
from
5bf2a26 to
f628808
Compare
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
This was
linked to
issues
Apr 1, 2025
Aniruddh25
reviewed
Apr 1, 2025
Aniruddh25
reviewed
Apr 1, 2025
Aniruddh25
requested changes
Apr 1, 2025
github-project-automation
bot
moved this from Todo
to Review In Progress
in Data API builder
RubenCerna2079
dismissed
aaronburtle’s stale review
The base branch was changed.
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
aaronburtle
reviewed
Apr 3, 2025
aaronburtle
approved these changes
Apr 3, 2025
Aniruddh25
reviewed
Apr 3, 2025
Aniruddh25
approved these changes
Apr 3, 2025
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
github-project-automation
bot
moved this from Review In Progress
to Done
in Data API builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes issues #2580 and #2582
What is this change?
Adds hot reload feature for loggers which makes it possible for the user to change the log level filters without restarting the application. This is done by ensuring that the logger factories are updated when there is a hot reload event.
This feature is also available in production mode, it is the only hot reloadable property in production mode.
How was this tested?
Test added:
Sample Request(s)
Before hot reload:
After hot reload:
