Write CacheTtl to entity when add/update command is used and CacheTtl is provided #2717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronburtle
requested review from
Alekhya-Polavarapu,
Aniruddh25,
RubenCerna2079,
anushakolan,
neeraj-sharma2592,
ravishetye,
rusamant,
sezal98,
sourabh1007,
souvikghosh04 and
vadeveka
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
Adds tracking for whether a user explicitly provided a cache TTL option when running the update command so that this flag is correctly written back to the configuration.
- Introduces
isCacheTtlUserProvidedto record if--cache.ttlwas specified - Updates return statements to include
UserProvidedTtlOptionsbased on that flag
Comments suppressed due to low confidence (2)
src/Cli/Utils.cs:846
- [nitpick] Consider renaming
isCacheTtlUserProvidedto match the property name (e.g.,userProvidedTtlOptions) for consistency withEntityCacheOptions.UserProvidedTtlOptions.
bool isCacheTtlUserProvided = false;
src/Cli/Utils.cs:859
- Add unit tests for scenarios when only
--cache.ttlis provided, when only--cache.enabledis provided, and when both are provided to verifyUserProvidedTtlOptionsis set correctly.
if (cacheTtl is not null)
…re/data-api-builder into dev/aaronburtle/CacheTtlUpdateBugFix
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
anushakolan
approved these changes
Jun 11, 2025
RubenCerna2079
pushed a commit
that referenced
this pull request
Jun 11, 2025
… is provided (#2717) ## Why make this change? Closes #2716 ## What is this change? When we create the entity cache options, we start with a new object and then later set the values for the fields. Because of this, the `bool` `UserProvidedTtlOptions` must explicitly be set when we later set these values or it will forever remain `false`. When it is false it is not written back out into the configuration file. ## How was this tested? Manually used the update command in the CLI to verify the field is written out. ## Sample Request(s) - Example REST and/or GraphQL request to demonstrate modifications - Example of CLI usage to demonstrate modifications
RubenCerna2079
added a commit
that referenced
this pull request
Jun 12, 2025
## Why make this change? When we create the entity cache options, we start with a new object and then later set the values for the fields. Because of this, the `bool` `UserProvidedTtlOptions` must explicitly be set when we later set these values or it will forever remain `false`. When it is false it is not written back out into the configuration file. ## What is this change? Fixes bug found in release candidate for 1.5 Cherry-picked PR: - #2717 ## How was this tested? ## Sample Request(s) Co-authored-by: aaronburtle <93220300+aaronburtle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #2716
What is this change?
When we create the entity cache options, we start with a new object and then later set the values for the fields. Because of this, the
boolUserProvidedTtlOptionsmust explicitly be set when we later set these values or it will forever remainfalse. When it is false it is not written back out into the configuration file.How was this tested?
Manually used the update command in the CLI to verify the field is written out.
Sample Request(s)