-
Notifications
You must be signed in to change notification settings - Fork 289
Properly Handle Invalid Type Conversion Errors in Delete REST Requests #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
seantleonard
merged 13 commits into
main
from
dev/seleonar/typeConversionErrorHandlingFix
Oct 21, 2022
Merged
Properly Handle Invalid Type Conversion Errors in Delete REST Requests #838
seantleonard
merged 13 commits into
main
from
dev/seleonar/typeConversionErrorHandlingFix
Oct 21, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aniruddh25
reviewed
Oct 12, 2022
src/Service/Resolvers/Sql Query Structures/SqlDeleteQueryStructure.cs
Outdated
Show resolved
Hide resolved
Aniruddh25
reviewed
Oct 12, 2022
Aniruddh25
requested changes
Oct 12, 2022
Collaborator
Aniruddh25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for checking GraphQL scenario.
jarupatj
suggested changes
Oct 13, 2022
src/Service/Resolvers/Sql Query Structures/BaseSqlQueryStructure.cs
Outdated
Show resolved
Hide resolved
…/github.com/Azure/data-api-builder into dev/seleonar/typeConversionErrorHandlingFix
Aniruddh25
reviewed
Oct 18, 2022
src/Service/Resolvers/Sql Query Structures/SqlDeleteQueryStructure.cs
Outdated
Show resolved
Hide resolved
Aniruddh25
approved these changes
Oct 18, 2022
Collaborator
Aniruddh25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after double checking 1 more question.
jarupatj
suggested changes
Oct 18, 2022
src/Service/Resolvers/Sql Query Structures/SqlDeleteQueryStructure.cs
Outdated
Show resolved
Hide resolved
jarupatj
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #835
What is this change?
How was this tested?
Sample Request(s)
URL: DELETE
/api/Book/id/{}Expected to fail with HTTP 400 Bad Request and NOT HTTP 5XX.