-
Notifications
You must be signed in to change notification settings - Fork 289
updating stored-procedure design doc #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating stored-procedure design doc #896
Conversation
…oc' of https://github.com/Azure/data-api-builder into dev/abhishekkuma/graphql-support-for-stored-procedure-doc
seantleonard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes requested to be clearer in explanations.
One general comment: why is much of this markdown document formatted as quotes using the ">" character?
Aniruddh25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for keeping our documentation up to date!
Co-authored-by: Ravi Shetye <ravishetye@gmail.com>
…oc' of https://github.com/Azure/data-api-builder into dev/abhishekkuma/graphql-support-for-stored-procedure-doc
seantleonard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a thread about JsonDocument -> JsonElement that wasn't changed. Can you also note why many sections of this markdown document are quoted with the > character?
Updated to JsonElement. most part of the document is quoted as '>' because this document was initially designed in that way to show every subsection to appear differently. I also think it makes it easier to follow each section. |
seantleonard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only reason I bring > up is because it is markdown block quote syntax and those sections are not quotes. I understand that they may be more readable, but I wonder if there is a better way to make it more readable.
Quotes make me think "this content is being quoted from somewhere... where is that?"
okay, I see your point now. |
Why make this change?
What is this change?
NOTE:
the doc contains images that might not be shown correctly on the Files changed tab. To view the images correctly head over to the branch file: https://github.com/Azure/data-api-builder/blob/dev/abhishekkuma/graphql-support-for-stored-procedure-doc/docs/internals/StoredProcedureDesignDoc.md