Config Files Generation for local development #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severussundar
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
jarupatj,
junsu0ms,
mbhaskar,
milismsft,
seantleonard and
tarazou9
as code owners
…s://github.com/Azure/data-api-builder into dev/shyamsundarj/config-generation-doc-changes
seantleonard
requested changes
Oct 31, 2022
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
Few suggestions and questions
Aniruddh25
reviewed
Oct 31, 2022
Aniruddh25
reviewed
Oct 31, 2022
Aniruddh25
reviewed
Oct 31, 2022
Aniruddh25
previously requested changes
Oct 31, 2022
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Need instructions for Visual Studio builds
aaronburtle
reviewed
Nov 1, 2022
seantleonard
approved these changes
Nov 29, 2022
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
Some suggestions, otherwise looks good
abhishekkumams
approved these changes
Nov 30, 2022
severussundar
dismissed
Aniruddh25’s stale review
I've incorporated the suggestions
severussundar
deleted the
dev/shyamsundarj/config-generation-doc-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
hawaiicommands todab