Skip to content

Conversation

@severussundar
Copy link
Contributor

What is this change?

  • Documentation changes that aims to outline the steps for generating the config files in local along with build
  • Re-naming the hawaii commands to dab

@severussundar severussundar added this to the Oct2022 milestone Oct 30, 2022
@severussundar severussundar self-assigned this Oct 30, 2022
@severussundar severussundar added the documentation Improvements or additions to documentation label Oct 30, 2022
Copy link
Contributor

@seantleonard seantleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions and questions

Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need instructions for Visual Studio builds

@Aniruddh25 Aniruddh25 modified the milestones: Oct2022, Nov2022 Nov 3, 2022
Copy link
Contributor

@seantleonard seantleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, otherwise looks good

@severussundar severussundar dismissed Aniruddh25’s stale review November 30, 2022 16:02

I've incorporated the suggestions

@severussundar severussundar merged commit 3fed50a into main Nov 30, 2022
@severussundar severussundar deleted the dev/shyamsundarj/config-generation-doc-changes branch November 30, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants