-
Notifications
You must be signed in to change notification settings - Fork 288
Fix Update CLI command for Stored Procedure #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
abhishekkumams
merged 6 commits into
main
from
dev/abhishekkuma/fix_cli_stored_procedure_update
Nov 21, 2022
Merged
Fix Update CLI command for Stored Procedure #987
abhishekkumams
merged 6 commits into
main
from
dev/abhishekkuma/fix_cli_stored_procedure_update
Nov 21, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayush3797
approved these changes
Nov 21, 2022
ravishetye
reviewed
Nov 21, 2022
severussundar
approved these changes
Nov 21, 2022
ravishetye
approved these changes
Nov 21, 2022
Co-authored-by: Shyam Sundar J <shyamsundarj@microsoft.com>
severussundar
approved these changes
Nov 21, 2022
Aniruddh25
reviewed
Nov 21, 2022
| ""param2"": ""hello"", | ||
| ""param3"": true | ||
| }, | ||
| ""key-fields"": [] |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: since its a stored procedure, why do we even bother to mention key-fields here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
Enumerable.Any()along with null, to not change the parameters if nothing is provided from user.How was this tested?
Steps To Verify
Initializing and adding a stored procedure entity
dab init -c test.json --database-type mssqldab add Sptest -c test.json --source s001.test --source.type "stored-procedure" --source.params "id:1,name:Abhi" --permissions "anonymous:read"Output
updating the source name
dab add Sptest -c test.json --source dbo.sptestOutput