This repository was archived by the owner on Oct 11, 2023. It is now read-only.
bug fix in Gateway #141
Merged
bug fix in Gateway #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arry body. Setting body on HTTP status such as 204 will cause exception. This repros today already by going through a bike renting flow and examine the logs of Gateway container. If running under a debugger, the exception will fail the request. Fix the issue by skipping setting HTTP body for 204, 205 and 304. This is what asp.net core checks in AspNetCore\src\Servers\Kestrel\Core\src\Internal\Http\ HttpProtocol.cs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequestLoggingMiddleware is not aware certain HTTP response can not carry body, such as 204.
Setting body on HTTP 204, 205 and 304 will cause exception as it is not supported, see AspNetCore\src\Servers\Kestrel\Core\src\Internal\Http\HttpProtocol.cs, ThrowWritingToResponseBodyNotSupported.
To repro, run the bike sharing application, go through a bike rental process and check the output of the Gateway container. You will see exception about WritingToResponseBodyNotSupported. The web site appears to still function though.
Fix the issue by skipping setting HTTP body for 204, 205 and 304.