Skip to content
This repository was archived by the owner on Oct 11, 2023. It is now read-only.

Fix bug with ingress host for gateway service #199

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Fix bug with ingress host for gateway service #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/bikes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

jobs:
build:
runs-on: ubuntu-16.04
runs-on: ubuntu-latest
steps:

- uses: actions/checkout@master
Expand Down Expand Up @@ -48,12 +48,11 @@ jobs:

- name: Helm Install PR
run: |
helm init --upgrade --wait
helm upgrade --install --namespace $GITHUB_HEAD_REF bikesharing-$GITHUB_HEAD_REF samples/BikeSharingApp/Bikes/charts/bikes \
--set image.repository=${{ secrets.CONTAINER_REGISTRY }}/bikes \
--set image.tag=$GITHUB_SHA \
--set imagePullSecrets[0].name=${{ secrets.IMAGE_PULL_SECRET }} \
--set ingress.hosts[0]=$GITHUB_HEAD_REF.s.${{ secrets.MASTER_SPACE }}.bikesharing.${{ secrets.HOST_SUFFIX }} \
--set ingress.annotations.kubernetes\\.io/ingress\\.class=traefik-azds
--set imagePullSecrets[0].name=${{ secrets.IMAGE_PULL_SECRET }}

- uses: azure/dev-spaces/actions/add-review-url@Releases/v1
with:
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/bikesharing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
build:
runs-on: ubuntu-16.04
runs-on: ubuntu-latest
steps:

- uses: actions/checkout@master
Expand Down Expand Up @@ -61,6 +61,7 @@ jobs:
cd samples/BikeSharingApp/charts
helm init --client-only
helm dependency update
helm init --upgrade --wait
helm upgrade --install --namespace ${{ secrets.MASTER_SPACE }} bikesharing . \
--set bikes.image.repository=${{ secrets.CONTAINER_REGISTRY }}/bikes \
--set bikes.imagePullSecrets[0].name=${{ secrets.IMAGE_PULL_SECRET }} \
Expand All @@ -76,7 +77,7 @@ jobs:
--set gateway.image.repository=${{ secrets.CONTAINER_REGISTRY }}/gateway \
--set gateway.imagePullSecrets[0].name=${{ secrets.IMAGE_PULL_SECRET }} \
--set gateway.image.tag=$GITHUB_SHA \
--set gateway.ingress.hosts[0]=${{ secrets.HOST }} \
--set gateway.ingress.hosts[0]=${{ secrets.MASTER_SPACE }}.gateway.${{ secrets.HOST_SUFFIX }} \
--set gateway.ingress.annotations.kubernetes\\.io/ingress\\.class=traefik-azds \
--set reservation.image.repository=${{ secrets.CONTAINER_REGISTRY }}/reservation \
--set reservation.imagePullSecrets[0].name=${{ secrets.IMAGE_PULL_SECRET }} \
Expand Down