This repository was archived by the owner on Oct 11, 2023. It is now read-only.
Update bikes.yml by adding a new step that updates the user's branch … #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name such that a valid namespace can be created using that. This also needs an update to the existing add-review-url custom action. There is a new input that is passed in to this action to construct the url which contains the valid child namespace. Note: there is another update needed such that we call the version2 of the custom github action: add-review-url@Releases/v2
stepro
suggested changes
Nov 5, 2019
…name specs and Release spec for the Helm install command in bikes.yml. Update some of the variable names. Tested E2E. This will need a Release/v2 branch which will contain node_modules as well.
…view-url such that the user specifies http vs https as needed. If not specified the protocol defaults to http. Update bikes.yml to add a step for installing helm for client if client and server version does not match. Add a step to create a valid release-name based on spec for the same by formatting the GITHUB_HEAD_REF environment variable.
stepro
suggested changes
Nov 7, 2019
…r installing Helm into in case the client version does not match the server version.
stepro
reviewed
Nov 7, 2019
…uli/childnamespaceUpdate
…nd clean-up and make it faster by updating the command-kubectl label namespace
stepro
approved these changes
Nov 8, 2019
…ep: Create child namespaces and add Dev Spaces labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update bikes.yml by adding a new step that updates the user's branch name such that a valid namespace can be created using that. This also needs an update to the existing add-review-url custom action. There is a new input that is passed in to this action to construct the url which contains the valid child namespace. Note: there is another update needed such that we call the version2 of the custom github action: add-review-url@Releases/v2