-
Notifications
You must be signed in to change notification settings - Fork 18
feat: setup controller runtime logger #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Title(Describe updated until commit bb855b2)Setup Controller Runtime Logger in Main Files Description
Changes walkthrough 📝
|
PR Reviewer Guide 🔍(Review updated until commit bb855b2)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨ |
1 similar comment
PR Code Suggestions ✨ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
==========================================
+ Coverage 80.50% 80.55% +0.04%
==========================================
Files 29 29
Lines 4099 4099
==========================================
+ Hits 3300 3302 +2
Misses 634 634
+ Partials 165 163 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
Sets up logger for controller runtime to remove stack trace.
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
Special notes for your reviewer
Refer to kubefleet-dev/kubefleet#42