-
Notifications
You must be signed in to change notification settings - Fork 17
feat: add feature gate for networking #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
==========================================
- Coverage 67.55% 67.45% -0.11%
==========================================
Files 34 34
Lines 5046 5060 +14
==========================================
+ Hits 3409 3413 +4
- Misses 1449 1458 +9
- Partials 188 189 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any way to add some e2e tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
39a0a40 to
f75d462
Compare
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
|
Newly added e2e test run: https://github.com/Azure/fleet-networking/actions/runs/17081304237/job/48435631932 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add a feature flag for networking services to be able to enable and disable when supported or not.
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
Created and upstream fleet similar with a hub cluster that checks for networking agents.
Installed no fleet networking crds on member cluster.

User cannot create service export on member.

Installed the agent with the latest changes.

All member clusters joined.

Heartbeats are still being updated.

Agents updated:

Special notes for your reviewer