Skip to content

Conversation

@britaniar
Copy link
Contributor

@britaniar britaniar commented Aug 14, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add a feature flag for networking services to be able to enable and disable when supported or not.

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Created and upstream fleet similar with a hub cluster that checks for networking agents.

Installed no fleet networking crds on member cluster.
image

User cannot create service export on member.
image

Installed the agent with the latest changes.
image

All member clusters joined.
image

Heartbeats are still being updated.
image

Agents updated:
image

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 3.92157% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.45%. Comparing base (b6b9d37) to head (daad94f).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cmd/member-net-controller-manager/main.go 0.00% 28 Missing ⚠️
cmd/mcs-controller-manager/main.go 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   67.55%   67.45%   -0.11%     
==========================================
  Files          34       34              
  Lines        5046     5060      +14     
==========================================
+ Hits         3409     3413       +4     
- Misses       1449     1458       +9     
- Partials      188      189       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@britaniar britaniar changed the title add feature gate for networking feat: add feature gate for networking Aug 14, 2025
@britaniar britaniar marked this pull request as ready for review August 15, 2025 00:01
Copy link
Contributor

@ryanzhang-oss ryanzhang-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any way to add some e2e tests?

Copy link
Member

@jim-minter jim-minter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
@britaniar britaniar force-pushed the networkingFeatureGate branch from 39a0a40 to f75d462 Compare August 19, 2025 21:20
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
@britaniar
Copy link
Contributor Author

@britaniar britaniar merged commit f877730 into Azure:main Aug 21, 2025
9 of 11 checks passed
@britaniar britaniar deleted the networkingFeatureGate branch August 21, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants