Feat: Add AppDeployment Adapter and Unit Tests #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ninjadq
commented
Apr 11, 2025
ninjadq
commented
- Introduced AppDeploymentAdapter to manage application deployment lifecycle, including validation, finalizer management, dependency readiness, and job handling.
- Implemented unit tests for the AppDeploymentAdapter to ensure functionality across various scenarios, including application validation, finalizer operations, and job completion checks.
- Generated mock interfaces for the AppDeploymentAdapter to facilitate testing and improve code maintainability.
- Introduced AppDeploymentAdapter to manage application deployment lifecycle, including validation, finalizer management, dependency readiness, and job handling. - Implemented unit tests for the AppDeploymentAdapter to ensure functionality across various scenarios, including application validation, finalizer operations, and job completion checks. - Generated mock interfaces for the AppDeploymentAdapter to facilitate testing and improve code maintainability.
- Added CustomResourceDefinitions (CRDs) for Cache, Operation, and Requirement resources, including their schemas and metadata. - Updated RBAC roles to include permissions for managing Cache, Operation, and Requirement resources. - Added dependencies for logr and mock libraries in go.mod to enhance logging and testing capabilities.
- Replaced hardcoded OpId string with a constant in the AppDeployment test file for improved maintainability and consistency across tests. - Updated multiple test cases to utilize the new constant instead of the previous hardcoded value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.