Refactor operation and requirement handling #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the `ClearConditions` function and its associated test from the `operation` package. - Introduced `OperationHelper` struct with methods for operation management, including condition clearing and ID generation. - Added tests for `OperationHelper` methods, ensuring functionality for diffing app deployments and comparing job specifications. - Deleted unused constants and introduced `RequirementHelper` for managing requirement conditions. - Implemented tests for `RequirementHelper`, covering condition updates and cache miss checks. - Added utility functions for generating random strings. - Updated integration tests to remove dependencies on removed constants and ensure proper phase checks. - Generated mock implementations for client interfaces to facilitate testing.
- Implemented `TestAppCacheFieldFromApplicationTeardown` to validate the extraction of cache fields from application teardown specifications. - Implemented `TestAppCacheFieldFromApplicationProvision` to validate the extraction of cache fields from application provision specifications. - Enhanced `CompareProvisionJobs` to utilize a helper function for comparing dependencies, ensuring consistent behavior. - Added comprehensive test cases for comparing provision jobs, including scenarios with identical jobs, different dependencies, and empty dependencies. - Introduced utility functions for comparing string slices and environment variables to streamline comparison logic. - Updated existing tests to reflect changes in the comparison logic and ensure thorough coverage of edge cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClearConditionsfunction and its associated test from theoperationpackage.OperationHelperstruct with methods for operation management, including condition clearing and ID generation.OperationHelpermethods, ensuring functionality for diffing app deployments and comparing job specifications.RequirementHelperfor managing requirement conditions.RequirementHelper, covering condition updates and cache miss checks.