Potential fix for code scanning alert no. 1: DOM text reinterpreted as HTML #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
hdamecharla
requested review from
devanshjainms and
dhruvmicrosoft
and removed request for
dhruvmicrosoft
devanshjainms
approved these changes
Mar 21, 2025
Contributor
devanshjainms
left a comment
devanshjainms
left a comment
There was a problem hiding this comment.
Thanks for fixing this security issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Azure/sap-automation-qa/security/code-scanning/1
To fix the problem, we need to ensure that any text content derived from the DOM is properly escaped before being reinserted as HTML. This can be achieved by using a text node instead of setting
innerHTMLdirectly. We will create text nodes for the JSON keys and values to ensure that any special characters are properly escaped.innerHTMLwith the creation of text nodes.formatJSONfunction to use text nodes instead of constructing HTML strings.Suggested fixes powered by Copilot Autofix. Review carefully before merging.