added functionality for key-vault authentication #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masking subid from the file with `xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to enhance the automation scripts by integrating Key Vault for secret management and adding necessary checks for Managed Service Identity (MSI) permissions. The most important changes include the addition of Key Vault parameters, a new function to check MSI permissions, and modifications to support Key Vault authentication.
Key Vault Integration:
WORKSPACES/SYSTEM/DEV-WEEU-SAP01-X00/sap-parameters.yaml: Added Key Vault parameters includingkey_vault_name,secret_name,msi_name, andresource_group.MSI Permissions Check:
scripts/sap_automation_qa.sh: Added thecheck_msi_permissionsfunction to ensure the MSI has the required permissions on the Key Vault.Authentication Enhancements:
scripts/sap_automation_qa.sh: Modified therun_ansible_playbookfunction to support Key Vault authentication by retrieving secrets from the Key Vault and using them for authentication.scripts/sap_automation_qa.sh: Updated themainfunction to handle the newKEYVAULTauthentication type and ensure Key Vault parameters are set.