Skip to content

Conversation

@dhruvmicrosoft
Copy link
Contributor

This pull request includes significant changes to the scripts/sap_automation_qa.sh script to enhance functionality and improve error handling. Additionally, new parameters were added to the sap-parameters.yaml file.

Enhancements to sap_automation_qa.sh:

  • Added global variable temp_file to store the path of the temporary file.
  • Introduced retrieve_secret_from_key_vault function to securely retrieve secrets from Azure Key Vault using MSI authentication.
  • Enhanced run_ansible_playbook function to handle SSH key and VM password retrieval from Azure Key Vault and manage temporary files securely.
  • Improved logging and error handling across various functions, including check_file_exists and extract_error_message. [1] [2]

Updates to sap-parameters.yaml:

  • Added key_vault_id and secret_id parameters to store Azure Key Vault information.

@dhruvmicrosoft dhruvmicrosoft requested a review from a team as a code owner April 7, 2025 17:22
@dhruvmicrosoft dhruvmicrosoft requested a review from KimForss April 7, 2025 17:22
@hdamecharla hdamecharla self-requested a review April 7, 2025 17:26
@hdamecharla hdamecharla self-assigned this Apr 7, 2025
Copy link
Member

@hdamecharla hdamecharla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@dhruvmicrosoft dhruvmicrosoft merged commit 3a276d2 into Azure:development-april25 Apr 7, 2025
10 checks passed
@dhruvmicrosoft dhruvmicrosoft deleted the key_vault_fetch branch April 7, 2025 17:30
devanshjainms pushed a commit to devanshjainms/sap-automation-qa that referenced this pull request Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants