Hotfix update that includes some minor bug fixes and improvements in docs

[devanshjainms]

This pull request includes several updates to the SAP Testing Automation Framework documentation, codebase, and dependencies. The changes improve documentation clarity, update dependencies, and enhance functionality in specific modules and tasks.

Documentation updates:

• README.md: Added images and a badge for GitHub issues to improve the visual appeal and provide quick access to issue tracking.
• docs/HIGH_AVAILABILITY.md: Updated instructions to fork the repository before cloning and added a new section on updating the framework to keep forks up to date with the latest changes. [1] [2]

Dependency updates:

• requirements.in: Added various packages for Ansible, Azure, development tools, testing, data processing, core utilities, and CLI tools to ensure all necessary dependencies are included.

Code enhancements:

• src/modules/filesystem_freeze.py: Added a new parameter database_sid to the FileSystemFreeze class and updated the _find_filesystem method to account for the database SID when finding the filesystem. [1] [2] [3]
• src/modules/get_pcmk_properties_db.py and src/modules/get_pcmk_properties_scs.py: Modified the _parse_resource method to strip trailing 's' from timeout and interval values to ensure consistency. [1] [2]

Task adjustments:

• src/roles/ha_db_hana/tasks/block-network.yml: Consolidated node connectivity checks and updated post-validation task includes to use a common file. [1] [2] [3]
• src/roles/ha_db_hana/tasks/fs-freeze.yml, src/roles/ha_db_hana/tasks/primary-crash-index.yml, src/roles/ha_db_hana/tasks/primary-echo-b.yml: Updated post-validation task includes to use a common file. [1] [2] [3] [4] [5] [6] [7]

Configuration updates:

• src/roles/ha_db_hana/tasks/files/constants.yaml: Removed trailing 's' from interval and timeout values in resource defaults to ensure consistency. [1] [2] [3]

[Copilot]

Copilot reviewed 33 out of 34 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

• requirements.in: Language not supported

Comments suppressed due to low confidence (2)

src/roles/ha_db_hana/tasks/secondary-node-kill.yml:101

• Ensure that replacing the specialized post validations task file with the common 'post-validations.yml' file handles all validation scenarios correctly, as this change affects error handling and task flow.

ansible.builtin.include_tasks:    "roles/misc/tasks/post-validations.yml"

src/modules/filesystem_freeze.py:108

• The updated logic to check for both '/hana/shared' and '/hana/shared/{self.database_sid}' assumes these are the only valid mount points. Confirm that this condition covers all intended filesystem configurations.

if len(parts) > 1 and parts[1] in [

[hdamecharla]

LGTM 🚀

[dennispadia]

Looks good.

[hdamecharla]

Approved

[dhruvmicrosoft]

LG!