Enhance SCS cluster status tests with additional resource attributes

[devanshjainms]

This pull request introduces several updates, primarily focusing on dependency upgrades, configuration enhancements, and the addition of new test cases and documentation for SAP high availability scenarios. Below is a categorized summary of the most important changes:

Dependency Updates

• Updated github/codeql-action versions across multiple workflow files (.github/workflows/codeql.yml, .github/workflows/ossf-scoreboard.yml, .github/workflows/trivy.yml) from v3.28.15 to v3.28.16 for improved security and performance. [1] [2] [3]

Configuration Enhancements

• Added user_assigned_identity_client_id parameter in sap-parameters.yaml to support Azure user-assigned managed identities.
• Updated HIGH_AVAILABILITY.md to include guidance on configuring user-assigned managed identities and their client IDs for Azure RBAC.

New Test Cases

• Introduced new test cases in SCS_HIGH_AVAILABILITY.md, such as Azure Load Balancer validation, SAPControl configuration validation, and various failover and process simulation scenarios. These tests ensure robustness in high availability setups.

Pseudocode Documentation

• Added detailed pseudocode documentation for new test cases, including:
  • HAFailoverToNodeTest for controlled failover validation.
  • KillMessageServerTest and related process-specific tests for simulating failures.
  • ManualRestartASCSInstanceTest for validating manual ASCS instance restarts.
  • SAPControlConfigValidationTest for verifying SAPControl configurations.

Enhanced Test Scenarios

• Extended existing pseudocode to include ASCS-specific scenarios for network blocking, node crashes, and resource migrations, ensuring comprehensive coverage of high availability behaviors. [1] [2] [3]

[Copilot]

Pull Request Overview

This pull request enhances the SCS status tests and associated documentation by introducing additional resource attribute handling, new HA pseudocode test cases, and dependency updates for improved security and performance. Key changes include:

• Extended functionality in SCSClusterStatusChecker to extract ASCS/ERS resource IDs and detailed resource attributes.
• Addition of new test cases and pseudocode documentation for SAP high availability scenarios.
• Upgraded dependency versions in GitHub workflows and configuration enhancements for Azure managed identities.

Reviewed Changes

Copilot reviewed 79 out of 80 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/modules/get_cluster_status_scs.py	Enhanced resource attribute extraction and updated node attribute processing.
src/modules/get_cluster_status_db.py	Updated parameter naming and XML element lookup.
src/modules/get_azure_lb.py	Added MSI Client ID parameter and improved error messaging.
src/modules/filesystem_freeze.py	Updated examples and documentation for filesystem freeze operations.
src/module_utils/get_cluster_status.py	Updated parameter naming for clarity in XML processing.
docs/*	New and revised pseudocode documentation for various HA test scenarios.
.github/workflows/*	Upgraded CodeQL action versions for dependency updates.
WORKSPACES/SYSTEM/DEV-WEEU-SAP01-X00/sap-parameters.yaml	Added user assigned managed identity configuration.

Files not reviewed (1)

• requirements.in: Language not supported

[hdamecharla]

Approved