Skip to content

Conversation

@devanshjainms
Copy link
Contributor

This pull request introduces several enhancements and updates to the SAP Testing Automation Framework, including support for Azure Shared Disks, improved command-line argument parsing, and the addition of new enumerations and data classes. The changes aim to enhance high availability documentation, streamline script execution, and improve code modularity.

Documentation Updates:

  • Added support for Azure Shared Disks (ASD) as a high availability option for SAP Central Services and SAP HANA in docs/HIGH_AVAILABILITY.md. Updated the cluster type options to include "ASD". [1] [2]
  • Introduced a new section on credential files sourced from Azure Key Vault, detailing setup and authentication methods.

Script Enhancements:

  • Improved argument parsing in scripts/sap_automation_qa.sh to support verbosity flags, test groups, test cases, and additional Ansible variables. Added a show_usage function for better user guidance.
  • Enhanced run_ansible_playbook() to dynamically include filtered test configurations and additional variables, with robust handling for SSH key files. [1] [2]
  • Enabled verbosity in Ansible playbook execution and integrated argument parsing into the main() function. [1] [2] [3]

Code Modularity:

  • Refactored src/module_utils/commands.py to use the new OperatingSystemFamily enum for better readability and maintainability. [1] [2] [3]
  • Added src/module_utils/enums.py, defining enumerations for telemetry destinations, test statuses, operating system families, HANA SR providers, and data classes for parameters and results.

Setup Script Improvement:

  • Fixed the virtual environment creation and activation paths in scripts/setup.sh to ensure compatibility with the current directory structure. [1] [2]

@devanshjainms devanshjainms marked this pull request as ready for review June 24, 2025 21:34
@devanshjainms devanshjainms requested a review from a team as a code owner June 24, 2025 21:34
@devanshjainms devanshjainms requested review from KimForss, Copilot and hdamecharla and removed request for a team June 24, 2025 21:34

This comment was marked as outdated.

KimForss
KimForss previously approved these changes Jun 25, 2025
@KimForss KimForss self-assigned this Jun 25, 2025
Copy link
Member

@hdamecharla hdamecharla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hdamecharla hdamecharla requested a review from Copilot June 27, 2025 03:37
@hdamecharla hdamecharla self-assigned this Jun 27, 2025

This comment was marked as outdated.

@hdamecharla hdamecharla requested a review from Copilot June 27, 2025 06:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends SAP Testing Automation Framework support to include the SAPHanaSR-angi provider and ASD high availability options. Key changes include updates across test mocks and configuration parameters to replace the ansible_os_family parameter with the new saphanasr_provider, new YAML command definitions (e.g. get_hana_resource_id_saphanasr_angi), and documentation updates reflecting these provider enhancements.

Reviewed Changes

Copilot reviewed 74 out of 76 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/roles/* Updated test files to remove redundant ansible_os_family references and use saphanasr_provider
src/roles/misc/tasks/get-saphanasr-provider.yml New task file to determine and set the SAPHanaSR-angi provider for SUSE
src/modules/get_pcmk_properties_db.py Updated parameter handling to accept and convert saphanasr_provider from input data
docs/HIGH_AVAILABILITY.md Expanded HA options to include Azure Shared Disks (ASD) and updated related documentation
scripts/* Updated virtual environment path, argument parsing, and test filtering options
Comments suppressed due to low confidence (1)

src/modules/get_pcmk_properties_db.py:662

  • Normalize or validate the input string for 'saphanasr_provider' to handle case differences or unexpected values before converting it to the HanaSRProvider enum.
        saphanasr_provider=HanaSRProvider(module.params["saphanasr_provider"]),

@KimForss KimForss self-requested a review June 27, 2025 13:10
@devanshjainms devanshjainms merged commit baec97e into Azure:development-june-2025 Jun 27, 2025
6 checks passed
@devanshjainms devanshjainms deleted the sap-hanasr-angi branch June 27, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants