-
Notifications
You must be signed in to change notification settings - Fork 14
Extend support for SAPHanaSR-angi provider #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend support for SAPHanaSR-angi provider #90
Conversation
…er and update .gitignore for Ansible files
…rties_db and get_pcmk_properties_scs modules
hdamecharla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends SAP Testing Automation Framework support to include the SAPHanaSR-angi provider and ASD high availability options. Key changes include updates across test mocks and configuration parameters to replace the ansible_os_family parameter with the new saphanasr_provider, new YAML command definitions (e.g. get_hana_resource_id_saphanasr_angi), and documentation updates reflecting these provider enhancements.
Reviewed Changes
Copilot reviewed 74 out of 76 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/roles/* | Updated test files to remove redundant ansible_os_family references and use saphanasr_provider |
| src/roles/misc/tasks/get-saphanasr-provider.yml | New task file to determine and set the SAPHanaSR-angi provider for SUSE |
| src/modules/get_pcmk_properties_db.py | Updated parameter handling to accept and convert saphanasr_provider from input data |
| docs/HIGH_AVAILABILITY.md | Expanded HA options to include Azure Shared Disks (ASD) and updated related documentation |
| scripts/* | Updated virtual environment path, argument parsing, and test filtering options |
Comments suppressed due to low confidence (1)
src/modules/get_pcmk_properties_db.py:662
- Normalize or validate the input string for 'saphanasr_provider' to handle case differences or unexpected values before converting it to the HanaSRProvider enum.
saphanasr_provider=HanaSRProvider(module.params["saphanasr_provider"]),
This pull request introduces several enhancements and updates to the SAP Testing Automation Framework, including support for Azure Shared Disks, improved command-line argument parsing, and the addition of new enumerations and data classes. The changes aim to enhance high availability documentation, streamline script execution, and improve code modularity.
Documentation Updates:
docs/HIGH_AVAILABILITY.md. Updated the cluster type options to include "ASD". [1] [2]Script Enhancements:
scripts/sap_automation_qa.shto support verbosity flags, test groups, test cases, and additional Ansible variables. Added ashow_usagefunction for better user guidance.run_ansible_playbook()to dynamically include filtered test configurations and additional variables, with robust handling for SSH key files. [1] [2]main()function. [1] [2] [3]Code Modularity:
src/module_utils/commands.pyto use the newOperatingSystemFamilyenum for better readability and maintainability. [1] [2] [3]src/module_utils/enums.py, defining enumerations for telemetry destinations, test statuses, operating system families, HANA SR providers, and data classes for parameters and results.Setup Script Improvement:
scripts/setup.shto ensure compatibility with the current directory structure. [1] [2]