Refactor the conditional logic for task retrieving saphanasr_angi #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the conditional logic for retrieving the HANA resource ID for saphanasr_angi to improve readability and organization.
- Moved the "when" condition from the inner block to the task level.
- Ensured the conditional check uses a default value for saphanasr_provider.
Comments suppressed due to low confidence (1)
src/roles/ha_db_hana/tasks/resource-migration.yml:35
- [nitpick] Moving the 'when' condition to the task level improves readability. Please verify that this refactor does not inadvertently alter the intended execution flow, especially if other conditions are expected in the block.
when: saphanasr_provider | default('SAPHanaSR') == "SAPHanaSR-angi"
devanshjainms
added a commit
that referenced
this pull request
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a minor change to the
src/roles/ha_db_hana/tasks/resource-migration.ymlfile. The change refactors the conditional logic for determining when to execute the block that retrieves the HANA resource ID forsaphanasr_angi.src/roles/ha_db_hana/tasks/resource-migration.yml: Moved thewhencondition for the block to the task level for better readability and organization.