Add a rescue operation to handle network-related failures #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d firewall rule removal on primary node in block-network.yml during rescue operation
There was a problem hiding this comment.
Pull Request Overview
This pull request improves naming consistency in configuration documentation and enhances error handling for high availability network tests. The changes ensure proper cleanup of firewall rules when network tests fail and align configuration parameter naming with established conventions.
- Updated configuration parameter naming from
db_sidtodatabase_sidfor consistency - Added rescue operation to clean up firewall rules on test failures in HA network scenarios
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/HIGH_AVAILABILITY.md | Updated parameter name from db_sid to database_sid in example configuration |
| src/roles/ha_db_hana/tasks/block-network.yml | Added firewall cleanup rescue task for failed network tests |
…r and adjust os_type parameter to uppercase in SCS module; update swappiness value in constants.yaml for optimized performance.
…nfiguration; improve cleanup of temporary files.
devanshjainms
added a commit
that referenced
this pull request
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve naming consistency in configuration files and add a rescue operation to handle network-related failures in high availability setups.
Improvements to naming consistency:
docs/HIGH_AVAILABILITY.md: Renameddb_high_availabilitytodatabase_high_availabilityin the examplesap-parameters.yamlfile to align with naming conventions.Enhancements to high availability setup:
src/roles/ha_db_hana/tasks/block-network.yml: Added a rescue task to remove firewall rules on the primary node in case of test execution failure, ensuring proper cleanup and recovery during high availability network tests.