Development #1
Development #1
Conversation
src/App.tsx
Outdated
| @@ -0,0 +1,58 @@ | |||
| import { createBrowserRouter, RouterProvider } from "react-router-dom"; | |||
| import DefaultLayout from "./layouts/DefaultLayout"; | |||
There was a problem hiding this comment.
@BVPritesh Tsconfig alias Import statements Missing
src/App.tsx
Outdated
| import Dashboard from "./pages/admin/dashboard"; | ||
| import { AuthProvider } from "./contexts/AuthContext"; | ||
|
|
||
| const router = createBrowserRouter([ |
There was a problem hiding this comment.
@BVPritesh Routing should be defined in separate file
src/App.tsx
Outdated
| }, | ||
| ]); | ||
|
|
||
| function App() { |
There was a problem hiding this comment.
@BVPritesh Make all function name as per ES6 Standard
src/components/footer.tsx
Outdated
| @@ -0,0 +1,7 @@ | |||
| export default function Footer() { | |||
There was a problem hiding this comment.
@BVPritesh Define function type like : ReactElement
src/components/header.tsx
Outdated
| const { isAuthenticated, logout } = useAuth(); | ||
| const navigate = useNavigate(); | ||
|
|
||
| const [menuOpen, SetMenuOpen] = useState(false); |
src/components/header.tsx
Outdated
| }; | ||
|
|
||
| useEffect(() => { | ||
| function handleResize() { |
There was a problem hiding this comment.
@BVPritesh Function should be define outside of the useEffect
src/contexts/AuthContext.tsx
Outdated
| logout: () => void; | ||
| }; | ||
|
|
||
| const AuthContext = createContext<AuthContextType | undefined>(undefined); |
There was a problem hiding this comment.
@BVPritesh Context type define initial value as a null instead of undefined and always prefer default value null instead of undefined
src/pages/admin/dashboard.tsx
Outdated
| headers["Authorization"] = `Bearer ${token}`; | ||
| } | ||
|
|
||
| const res = await fetch("https://jsonplaceholder.typicode.com/posts", { |
There was a problem hiding this comment.
@BVPritesh Define api end point domain in environment file and api end points like post, create define in constant file
src/pages/admin/dashboard.tsx
Outdated
| } | ||
|
|
||
| const data: Post[] = await res.json(); | ||
| if (mounted) { |
There was a problem hiding this comment.
@BVPritesh Unwanted used of mounted variable remove it and adjust your logic
src/pages/admin/dashboard.tsx
Outdated
| }, [token]); | ||
|
|
||
| // Validation rules | ||
| const titleRegex = /^[A-Za-z\s]+$/; // letters and spaces only |
There was a problem hiding this comment.
@BVPritesh Validation rules should be define in separate file
src/pages/admin/dashboard.tsx
Outdated
| return Object.keys(errors).length === 0; | ||
| } | ||
|
|
||
| function showToast(message: string) { |
There was a problem hiding this comment.
@BVPritesh Create a common hook to show and hide the toaster message
src/pages/admin/dashboard.tsx
Outdated
| setTitle(""); | ||
| setBody(""); | ||
| setFormErrors({}); | ||
| setEditingId(null); |
There was a problem hiding this comment.
@BVPritesh Create a separate function to reset the value
No description provided.