Skip to content

Effect renderer: Restore the right values for the depth and stencil states #14092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Effect renderer: Restore the right values for the depth and stencil states #14092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/dev/core/src/Materials/effectRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ export class EffectRenderer {
private _fullscreenViewport = new Viewport(0, 0, 1, 1);
private _onContextRestoredObserver: Nullable<Observer<ThinEngine>>;

private _savedStateDepthTest: boolean;
private _savedStateStencilTest: boolean;

/**
* Creates an effect renderer
* @param engine the engine to use for rendering
Expand Down Expand Up @@ -98,6 +101,9 @@ export class EffectRenderer {
* @param effectWrapper Defines the effect to draw with
*/
public applyEffectWrapper(effectWrapper: EffectWrapper): void {
this._savedStateDepthTest = this.engine.depthCullingState.depthTest;
this._savedStateStencilTest = this.engine.stencilState.stencilTest;

this.engine.setState(true);
this.engine.depthCullingState.depthTest = false;
this.engine.stencilState.stencilTest = false;
Expand All @@ -110,8 +116,8 @@ export class EffectRenderer {
* Restores engine states
*/
public restoreStates(): void {
this.engine.depthCullingState.depthTest = true;
this.engine.stencilState.stencilTest = true;
this.engine.depthCullingState.depthTest = this._savedStateDepthTest;
this.engine.stencilState.stencilTest = this._savedStateStencilTest;
}

/**
Expand Down