Skip to content

SSAO2: Allow passing an existing instance of a geometry buffer renderer #17116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebavan merged 1 commit into from
Sep 3, 2025
Merged

SSAO2: Allow passing an existing instance of a geometry buffer renderer #17116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions packages/dev/core/src/PostProcesses/RenderPipeline/Pipelines/ssao2RenderingPipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { RegisterClass } from "../../../Misc/typeStore";
import { EngineStore } from "../../../Engines/engineStore";
import { SSAO2Configuration } from "../../../Rendering/ssao2Configuration";
import type { PrePassRenderer } from "../../../Rendering/prePassRenderer";
import type { GeometryBufferRenderer } from "../../../Rendering/geometryBufferRenderer";
import { GeometryBufferRenderer } from "../../../Rendering/geometryBufferRenderer";
import { Constants } from "../../../Engines/constants";
import type { Nullable } from "../../../types";
import { RandomRange } from "../../../Maths/math.scalar.functions";
Expand Down Expand Up @@ -121,6 +121,7 @@ export class SSAO2RenderingPipeline extends PostProcessRenderPipeline {
return this._textureSamples;
}

private _forcedGeometryBuffer: Nullable<GeometryBufferRenderer> = null;
/**
* Force rendering the geometry through geometry buffer.
*/
Expand All @@ -130,7 +131,7 @@ export class SSAO2RenderingPipeline extends PostProcessRenderPipeline {
if (!this._forceGeometryBuffer) {
return null;
}
return this._scene.geometryBufferRenderer;
return this._forcedGeometryBuffer ?? this._scene.geometryBufferRenderer;
}
private get _prePassRenderer(): Nullable<PrePassRenderer> {
if (this._forceGeometryBuffer) {
Expand Down Expand Up @@ -265,21 +266,33 @@ export class SSAO2RenderingPipeline extends PostProcessRenderPipeline {
}

/**
* @constructor
* Creates the SSAO2 rendering pipeline.
* @param name The rendering pipeline name
* @param scene The scene linked to this pipeline
* @param ratio The size of the postprocesses. Can be a number shared between passes or an object for more precision: { ssaoRatio: 0.5, blurRatio: 1.0 }
* @param cameras The array of cameras that the rendering pipeline will be attached to
* @param forceGeometryBuffer Set to true if you want to use the legacy geometry buffer renderer
* @param forceGeometryBuffer Set to true if you want to use the legacy geometry buffer renderer. You can also pass an existing instance of GeometryBufferRenderer if you want to use your own geometry buffer renderer.
* @param textureType The texture type used by the different post processes created by SSAO (default: Constants.TEXTURETYPE_UNSIGNED_BYTE)
*/
constructor(name: string, scene: Scene, ratio: any, cameras?: Camera[], forceGeometryBuffer = false, textureType = Constants.TEXTURETYPE_UNSIGNED_BYTE) {
constructor(
name: string,
scene: Scene,
ratio: any,
cameras?: Camera[],
forceGeometryBuffer: boolean | GeometryBufferRenderer = false,
textureType = Constants.TEXTURETYPE_UNSIGNED_BYTE
) {
super(scene.getEngine(), name);

this._scene = scene;
this._ratio = ratio;
this._textureType = textureType;
this._forceGeometryBuffer = forceGeometryBuffer;
if (forceGeometryBuffer instanceof GeometryBufferRenderer) {
this._forceGeometryBuffer = true;
this._forcedGeometryBuffer = forceGeometryBuffer;
} else {
this._forceGeometryBuffer = forceGeometryBuffer;
}

if (!this.isSupported) {
Logger.Error("The current engine does not support SSAO 2.");
Expand All @@ -291,7 +304,9 @@ export class SSAO2RenderingPipeline extends PostProcessRenderPipeline {

// Set up assets
if (this._forceGeometryBuffer) {
scene.enableGeometryBufferRenderer();
if (!this._forcedGeometryBuffer) {
scene.enableGeometryBufferRenderer();
}
if (scene.geometryBufferRenderer?.generateNormalsInWorldSpace) {
Logger.Error("SSAO2RenderingPipeline does not support generateNormalsInWorldSpace=true for the geometry buffer renderer!");
}
Expand Down Expand Up @@ -396,7 +411,7 @@ export class SSAO2RenderingPipeline extends PostProcessRenderPipeline {

this._randomTexture.dispose();

if (disableGeometryBufferRenderer) {
if (disableGeometryBufferRenderer && !this._forcedGeometryBuffer) {
this._scene.disableGeometryBufferRenderer();
}

Expand Down