Skip to content

Exclude atmosphere visual tests on mac+firefox #17291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 14, 2025
Merged

Exclude atmosphere visual tests on mac+firefox #17291

merged 7 commits into from
Oct 14, 2025
+33 −4

Conversation

georginahalpern
Copy link
Contributor

@georginahalpern georginahalpern commented Oct 14, 2025 •
edited
Loading

A WebGL warning is causing the atmosphere visual tests to fail on older versions of Firefox on Mac, so we want to exclude these tests in that browser+os combo.

The test is failing due to the below condition which captures warnings (even though this specific warning doesn't inhibit user from running playground)

warning: [Atmosphere Day] [JavaScript Warning: "WebGL warning: readPixels: Format and type RGBA/HALF_FLOAT incompatible with this RGBA16F attachment. This framebuffer requires either RGBA/FLOAT or getParameter(IMPLEMENTATION_COLOR_READ_FORMAT/_TYPE) RGBA/FLOAT."]

image

Tested out the change here: https://dev.azure.com/babylonjs/ContinousIntegration/_build/results?buildId=44754&view=logs&j=cfa20e98-6997-523c-4233-f0a7302c929f&t=79fc4877-465c-5c35-527d-07557a6ca745

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

Snapshot stored with reference name:
refs/pull/17291/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/17291/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17291/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17291/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17291/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17291/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/interactionplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/devhostplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/interactionplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/devhostplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/interactionplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/devhostplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/webgl2playwright/index.html

@georginahalpern georginahalpern changed the title Exclude atmosphere visual tests on mac+firefox/safari Exclude atmosphere visual tests on mac+firefox Oct 14, 2025
@georginahalpern georginahalpern marked this pull request as ready for review October 14, 2025 20:29
@sebavan sebavan enabled auto-merge (squash) October 14, 2025 20:30
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/interactionplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/devhostplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17291/merge/testResults/webgl2playwright/index.html

@sebavan sebavan merged commit 5f462f2 into BabylonJS:master Oct 14, 2025
19 of 20 checks passed
docEdub added a commit that referenced this pull request Oct 15, 2025
@docEdub
Revert "Exclude atmosphere visual tests on mac+firefox (#17291)"
b656068 
This reverts commit 5f462f2.
@docEdub docEdub mentioned this pull request Oct 15, 2025
Merged
docEdub added a commit that referenced this pull request Oct 15, 2025
@docEdub
Revert "Exclude atmosphere visual tests on mac+firefox" (#17302)
d0cf52c 
Reverts #17291

The visualization test config filter added for the atmosphere
visualization tests on macOS/Firefox is not needed anymore since
updating playwright in #17295 also fixes the atmosphere visualization
tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebavan sebavan sebavan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@georginahalpern @bjsplat @sebavan @docEdub