-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Disallow Inspector-v2 in Playground/Sandbox when old Babylon versions are specified #17296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow Inspector-v2 in Playground/Sandbox when old Babylon versions are specified #17296
Conversation
Defer dynamic import of inspector v2
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17296/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17296/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17296/merge#BCU1XR#0 |
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17296/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17296/merge/ |
Visualization tests for WebGPU |
Devhost visualization test reporter: |
WebGL2 visualization test reporter: |
I'm wondering if it would be good to add a CI test for this issue. Is there an easy way to check old versions of BJS work in the playground? |
I believe there are already some vis tests for showing inspector (v1). I imagine those could be updated to add more tests that try with old versions. |
This PR fixes an issue I missed where if in Playground/Sandbox you use an older version of Babylon, things can break. This is because we don't have old versions of inspector v2 that work with old versions of Babylon like we do with inspector v1 (plus we don't have a umd package right now, so we don't even have a means of loading older versions of inspector v2).
For now with this change, we only allow Inspector v2 when using the latest Babylon (e.g. no explicit version specified).