Skip to content

Conversation

ryantrem
Copy link
Member

This PR fixes an issue I missed where if in Playground/Sandbox you use an older version of Babylon, things can break. This is because we don't have old versions of inspector v2 that work with old versions of Babylon like we do with inspector v1 (plus we don't have a umd package right now, so we don't even have a means of loading older versions of inspector v2).

For now with this change, we only allow Inspector v2 when using the latest Babylon (e.g. no explicit version specified).

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17296/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17296/merge/?snapshot=refs/pull/17296/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17296/merge/

@sebavan sebavan enabled auto-merge (squash) October 14, 2025 22:40
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2025

@sebavan sebavan merged commit da2780e into BabylonJS:master Oct 14, 2025
21 of 22 checks passed
@docEdub
Copy link
Contributor

docEdub commented Oct 15, 2025

I'm wondering if it would be good to add a CI test for this issue. Is there an easy way to check old versions of BJS work in the playground?

@ryantrem
Copy link
Member Author

I believe there are already some vis tests for showing inspector (v1). I imagine those could be updated to add more tests that try with old versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants