Skip to content

Conversation

@docEdub
Copy link
Contributor

@docEdub docEdub commented Oct 29, 2025

When useCustomUnlockedButton is set to true on the old audio engine, it is still getting shown when the audio engine V2 implementation is initialized and it's state gets immediately set to suspended.

This change fixes the issue by checking the mute button's enabled flag before showing it.

…n` is set

When `useCustomUnlockedButton` is set to `true` on the old audio engine, it is still getting shown when the audio engine V2 implementation is initialized and it's state gets immediately set to `suspended`.

This change fixes the issue by checking the mute button's `enabled` flag before showing it.
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 29, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@docEdub docEdub enabled auto-merge (squash) October 29, 2025 14:30
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 29, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 29, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 29, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 29, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 29, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 29, 2025

@docEdub docEdub merged commit ff1b476 into BabylonJS:master Oct 29, 2025
20 checks passed
@docEdub docEdub deleted the 251029-fix-legacy-audio-engine-mute-button branch October 29, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants