Skip to content

GPUPicker: Fix picking ID precision issues #17404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2025
Merged

GPUPicker: Fix picking ID precision issues #17404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91c7a21
Fix picking ID precision issues in GPU picker
noname0310 Nov 5, 2025
f0a6f01
Use flat varying for vMeshID and remove rounding in picking shaders
noname0310 Nov 6, 2025
263c09d
Update picking.fragment.fx
noname0310 Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/dev/core/src/Collisions/gpuPicker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,6 @@ export class GPUPicker {
return;
}

this._pickableMeshes = list as Array<AbstractMesh>;

// Prepare target
const scene = ("mesh" in list[0] ? list[0].mesh : list[0]).getScene();
if (!this._cachedScene || this._cachedScene !== scene) {
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/core/src/Shaders/picking.fragment.fx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

#if defined(INSTANCES)
varying float vMeshID;
flat varying float vMeshID;
#else
uniform float meshID;
#endif
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/core/src/Shaders/picking.vertex.fx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ uniform mat4 viewProjection;

// Output
#if defined(INSTANCES)
varying float vMeshID;
flat varying float vMeshID;
#endif

void main(void) {
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/core/src/ShadersWGSL/picking.fragment.fx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

#if defined(INSTANCES)
varying vMeshID: f32;
flat varying vMeshID: f32;
#else
uniform meshID: f32;
#endif
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/core/src/ShadersWGSL/picking.vertex.fx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ uniform viewProjection: mat4x4f;

// Output
#if defined(INSTANCES)
varying vMeshID: f32;
flat varying vMeshID: f32;
#endif

@vertex
Expand Down