Skip to content

Geospatial Camera Keyboard Inputs and PinchToZoom #17466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 18, 2025
Merged

Geospatial Camera Keyboard Inputs and PinchToZoom #17466

merged 5 commits into from
Nov 18, 2025
+260 −8

Conversation

@georginahalpern
Copy link
Contributor

@georginahalpern georginahalpern commented Nov 17, 2025

  • Add keyboard inputs for geocam (pan/rotate/zoom)
  • Add pinchToZoom touch functionality

#17451

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 17, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@georginahalpern georginahalpern enabled auto-merge (squash) November 17, 2025 21:52
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 17, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

1 similar comment
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 17, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 17, 2025

Snapshot stored with reference name:
refs/pull/17466/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17466/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17466/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/17466/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17466/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17466/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17466/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17466/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 17, 2025

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17466/merge/testResults/interactionplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 17, 2025

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17466/merge/testResults/devhostplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 17, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17466/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 17, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17466/merge/testResults/webgpuplaywright/index.html

AmoebaChant
AmoebaChant reviewed Nov 17, 2025
View reviewed changes
Georgina Halpern added 2 commits November 17, 2025 18:22
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 17, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 17, 2025

Snapshot stored with reference name:
refs/pull/17466/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17466/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17466/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/17466/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17466/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17466/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17466/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17466/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 17, 2025

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17466/merge/testResults/interactionplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 18, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17466/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 18, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17466/merge/testResults/webgl2playwright/index.html

@georginahalpern georginahalpern merged commit 4d0ff4e into BabylonJS:master Nov 18, 2025
18 of 20 checks passed
@georginahalpern georginahalpern deleted the geoCamKeyboard branch November 18, 2025 00:08
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 18, 2025

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17466/merge/testResults/devhostplaywright/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AmoebaChant AmoebaChant AmoebaChant approved these changes

Assignees

No one assigned

Labels

camera new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@georginahalpern @bjsplat @AmoebaChant