Skip to content

Add enforceUniqueId parameter to material constructor #9488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Add enforceUniqueId parameter to material constructor #9488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Materials/material.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,15 +659,18 @@ export class Material implements IAnimatable {
* @param name defines the name of the material
* @param scene defines the scene to reference
* @param doNotAdd specifies if the material should be added to the scene
* @param enforceUniqueId true (default) to enforce unique ids for materials in the scene
*/
constructor(name: string, scene: Scene, doNotAdd?: boolean) {
constructor(name: string, scene: Scene, doNotAdd?: boolean, enforceUniqueId = true) {
this.name = name;
let idSubscript = 1;
this._scene = scene || EngineStore.LastCreatedScene;

this.id = name || Tools.RandomId();
while (this._scene.getMaterialByID(this.id)) {
this.id = name + " " + idSubscript++;
if (enforceUniqueId) {
while (this._scene.getMaterialByID(this.id)) {
this.id = name + " " + idSubscript++;
}
}

this.uniqueId = this._scene.getUniqueId();
Expand Down