Skip to content

Conversation

@CoPrez
Copy link
Contributor

@CoPrez CoPrez commented Nov 25, 2020

With this change I'm updating BabylonNative to the latest from master which exposes the tracking states. Along with updating BabylonNative I'm also adding in some improvements to the Playground app. I've updated the Playground app to display a message about what state XR tracking is in. Additionally I am checking in some VSCode settings that add debug targets and make deployment/testing easier within VSCode.

With these changes I performed the following manual tests on Android and iOS for Debug and Release flavors:

  1. Basic rendering - launch the Playground app and make sure the model loaded and is rendering at 60fps.
  2. Animation - make sure the loaded model is animating.
  3. Input handling - swipe across the display and make sure the model rotates around the y-axis.
  4. Display rotation - rotate the device 90 degrees and make sure the view rotates and renders correctly.
  5. View replacement - tap the Toggle EngineView button twice to replace the render target view.
  6. Engine dispose - tap the Toggle EngineScreen button twice to dispose and re-instantiate the Babylon engine.
  7. Suspend/resume - switch to a different app and then back to the Playground and make sure it is still rendering correctly.
  8. Dev mode reload - in the Metro server console window, press the R key on the keyboard to reload the JS engine and make sure rendering restarts successfully.
  9. XR mode - tap the Start XR button and make sure XR mode is working.
  10. XR display rotation - rotate the device 90 degrees and make sure the view rotates and renders correctly.
  11. XR view replacement - tap the Toggle EngineView button twice to replace the render target view.
  12. XR suspend/resume - switch to a different app and then back to the Playground and make sure it is still rendering correctly.

@CoPrez CoPrez requested review from Alex-MSFT and ryantrem November 25, 2020 00:54
@CoPrez CoPrez self-assigned this Nov 25, 2020
@Alex-MSFT
Copy link
Contributor

Note - I'm currently investigating why Dev mode reload is not passing with my changes

Dev mode reload is a known issue #19, not a regression from this change

@ryantrem
Copy link
Member

I discovered late last week that dev mode reload is broken when a glb has been loaded. Try commenting out the glb load in App.tsx.

CoPrez and others added 3 commits November 30, 2020 15:30
Co-authored-by: Alex-MSFT <altran@microsoft.com>
Co-authored-by: Ryan Tremblay <ryantrem@msn.com>
Co-authored-by: Alex-MSFT <altran@microsoft.com>
@CoPrez CoPrez merged commit 0572e64 into BabylonJS:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants