-
Notifications
You must be signed in to change notification settings - Fork 68
Update to latest BabylonNative with tracking states exposed #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dev mode reload is a known issue #19, not a regression from this change |
Alex-MSFT
reviewed
Nov 25, 2020
Alex-MSFT
reviewed
Nov 25, 2020
Alex-MSFT
reviewed
Nov 25, 2020
Alex-MSFT
reviewed
Nov 25, 2020
Alex-MSFT
reviewed
Nov 25, 2020
Alex-MSFT
approved these changes
Nov 25, 2020
Member
|
I discovered late last week that dev mode reload is broken when a glb has been loaded. Try commenting out the glb load in App.tsx. |
ryantrem
reviewed
Nov 30, 2020
Co-authored-by: Alex-MSFT <altran@microsoft.com> Co-authored-by: Ryan Tremblay <ryantrem@msn.com>
Co-authored-by: Alex-MSFT <altran@microsoft.com>
ryantrem
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change I'm updating BabylonNative to the latest from master which exposes the tracking states. Along with updating BabylonNative I'm also adding in some improvements to the Playground app. I've updated the Playground app to display a message about what state XR tracking is in. Additionally I am checking in some VSCode settings that add debug targets and make deployment/testing easier within VSCode.
With these changes I performed the following manual tests on Android and iOS for Debug and Release flavors:
Rkey on the keyboard to reload the JS engine and make sure rendering restarts successfully.