Min support for manual rendering (as an implementation detail) #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a RenderView function
chrisfromwork
approved these changes
Jan 13, 2021
Contributor
chrisfromwork
left a comment
chrisfromwork
left a comment
There was a problem hiding this comment.
This seems like it should address UWP needs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the minimum needed to easily support manual rendering in the shared Babylon Native / React Native integration layer. Android and iOS continue to use automatic rendering, but this should let us use the shared code for the React Native for Windows integration (where we need to do manual rendering). Later we should expose something like
BeginRenderingView/EndRenderingViewto allow for more efficient render loops, but the RNW integration as is does not use that, so that's an improvement we can make later. We also need to sort out how to do theResetViewlogic in the manual rendering case, but that already has other issues we need to figure out in the RNW integration. So again, min changes needed to bring the in-progress RNW integration onto the shared code.