-
Notifications
You must be signed in to change notification settings - Fork 68
Fix native input usage for uwp #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } | ||
| }); | ||
|
|
||
| _inputLoopWorker = ThreadPool::RunAsync(workItemHandler, WorkItemPriority::High, WorkItemOptions::TimeSliced); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to move this off the main thread?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a suggestion from @tymlipari they may have more context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have to right now, but CoreIndependentInputSource supports this in general. If we ever want to move the Babylon rendering off-thread, we can similarly move the input sink with it.
Modules/@babylonjs/react-native/windows/BabylonReactNative/EngineView.cpp
Show resolved
Hide resolved
|
Does pointer capture work here? Meaning, if I press down within the window and then drag the cursor outside the window bounds without releasing, does Babylon continue to receive the input? For things like camera manipulation and such that'd be a necessary feature, and we might need a mechanism to mark the pointers as captured until we're done with them. |
|
Modules/@babylonjs/react-native/windows/BabylonReactNative/EngineView.cpp
Show resolved
Hide resolved
Modules/@babylonjs/react-native/windows/BabylonReactNative/EngineView.cpp
Outdated
Show resolved
Hide resolved
Modules/@babylonjs/react-native/android/src/main/cpp/BabylonNativeInterop.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Ryan Tremblay <ryantrem@msn.com>
Co-authored-by: Ryan Tremblay <ryantrem@msn.com>
This review contains the following changes:
We should not check in this review until the following is completed:
we will also need to update the submodule commit to this BabylonNative pr commit once its completed.