Fix android and ios support #147
Conversation
| abiFilters "arm64-v8a", "armeabi-v7a", "x86" | ||
| } | ||
| packagingOptions { | ||
| // TODO if def based on gradle version where we only do this for 4.0.0+? |
There was a problem hiding this comment.
we can probably remove this comment, libBabylonNative.so is the only lib we distribute and this exclude isn't included in the npm package build.gradle file. @ryantrem are we okay with having everyone build the libBabylonNative.so with gradle 4.1.0?
There was a problem hiding this comment.
I have 3.5 and this didn't break anything for me, so I think we could just update the comment to say that this is to support the Android gradle plugin 4.0.0+. Please call it "Android gradle plugin" though and not "gradle", because they are versioned differently. We are using gradle version 6.7.
There was a problem hiding this comment.
this should now be fixed
chrisfromwork
changed the title
… one for testing with RN 0.64.0-rc.0 Change packages Android min api level back to 18
| if (abi != null) { // null for the universal-debug, universal-release variants | ||
| output.versionCodeOverride = | ||
| versionCodes.get(abi) * 1048576 + defaultConfig.versionCode | ||
| output.versionCodeOverride = versionCode |
There was a problem hiding this comment.
This doesn't seem to match upgrade helper.
There was a problem hiding this comment.
this should now be fixed
2 participants
Moving to react native 0.64.0 preview releases has caused regressions in android/ios. This review fixes those issues.