Add NativeCapture #156
Merged
Add NativeCapture #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test code in Babylon React Native
Contributor
NativeCapture needs added to these different platform specific library references. This should generate linker errors with pr ci Refers to: Modules/@babylonjs/react-native-windows/windows/BabylonReactNative/BabylonReactNative.vcxproj:205 in a5334b1. [](commit_id = a5334b1, deletion_comment = False) |
chrisfromwork
suggested changes
Feb 10, 2021
Contributor
chrisfromwork
left a comment
chrisfromwork
left a comment
There was a problem hiding this comment.
NativeCapture needs added to these different platform specific library references in BabylonReactNative.vcxproj. This should theoretically generate linker errors with pr ci
…ce and not packaged libs)
Alex-MSFT
approved these changes
Feb 11, 2021
|
|
||
| export type CaptureCallback = (capture: CapturedFrame) => void; | ||
|
|
||
| declare class NativeCapture { |
Contributor
There was a problem hiding this comment.
long term are we planning to have this defined somewhere in Babylon.js?
chrisfromwork
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NativeCaptureplugin was recently added to BabylonNative. This change pulls it into BabylonReactNative and adds a TypeScript wrapper. It also logs a warning if it is used since:This works toward (but doesn't fully solve) BabylonJS/BabylonNative#562
FYI @bonnyMahajan10