Skip to content

Package header files needed for IXrContext.h usage (OpenXR + UWP) #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 10, 2021
Merged

Package header files needed for IXrContext.h usage (OpenXR + UWP) #163

merged 14 commits into from
Mar 10, 2021

Conversation

@chrisfromwork
Copy link
Contributor

@chrisfromwork chrisfromwork commented Feb 25, 2021 •
edited
Loading

This review enables developers to build custom openxr extensions for react-native-windows/IXrContext.

@chrisfromwork
Copy link
Contributor Author

chrisfromwork commented Feb 25, 2021

this needs reverted once a commit exists in the BabylonJS repo for the needed changes

Refers to: .gitmodules:4 in e90c103. [](commit_id = e90c103, deletion_comment = False)

chrisfromwork
chrisfromwork commented Feb 25, 2021
View reviewed changes
@chrisfromwork chrisfromwork marked this pull request as ready for review March 1, 2021 21:56
rgerd
rgerd approved these changes Mar 10, 2021
View reviewed changes
@chrisfromwork @rgerd
Update Package/gulpfile.js
c40745e 
Co-authored-by: rgerd <rgerd@users.noreply.github.com>
ryantrem
ryantrem reviewed Mar 10, 2021
View reviewed changes
@chrisfromwork
Copy link
Contributor Author

chrisfromwork commented Mar 10, 2021

closing to reset build ci

@chrisfromwork chrisfromwork reopened this Mar 10, 2021
@chrisfromwork chrisfromwork merged commit 53a7580 into BabylonJS:master Mar 10, 2021
@chrisfromwork chrisfromwork mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryantrem ryantrem ryantrem left review comments

@satyapoojasama satyapoojasama Awaiting requested review from satyapoojasama

@rickfromwork rickfromwork Awaiting requested review from rickfromwork

@bghgary bghgary Awaiting requested review from bghgary

+2 more reviewers

@tymlipari tymlipari tymlipari approved these changes

@rgerd rgerd rgerd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chrisfromwork @tymlipari @rgerd @ryantrem