Enable fast refresh for UWP scenarios #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantrem
reviewed
Mar 12, 2021
| #else | ||
| JavaScriptMainModuleName(L"index"); | ||
| InstanceSettings().UseWebDebugger(true); | ||
| InstanceSettings().UseWebDebugger(false); // BabylonReactNative accesses the jsi runtime, which isn't possible with the web debugger |
Member
There was a problem hiding this comment.
On other platforms, web debugger (remote debugging) is enabled/disabled dynamically from the app's debug/developer menu. Is this different on Windows? It would be annoying if all UWP RN apps have to change this configuration in order to use Babylon React Native.
Contributor
Author
There was a problem hiding this comment.
it sounds like it may be possible to set this dynamically, but i'm still trying to track down documentation on how. For the time being, this hardcoding of the ip address is a valid workaround/has been allowing me to test things on hololens 2
ryantrem
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-native-windows 0.64.0-preview.15 contains jsi runtime fixes that allow fast refresh to work for UWP scenarios. This change updates package dependencies to 0.64.0-preview.15. UWP app instance settings have also been updated to use fast refresh for debug builds.
note: there are still issues around fast refresh when in an immersive xr session